fix(model): execute valid write operations if calling bulkWrite() with ordered: false
#13218
Conversation
…ith ordered: false Fix #13176
|
You have successfully added a new CodeQL configuration |
There was a problem hiding this comment.
i am not very familiar with this part of the code, so i cannot say much about it
I'm not thrilled with the fact that bulkWrite() doesn't throw an error if some operations failed validation, but that is consistent with how insertMany() works
i also think if there are errors it should throw by default, but maybe also allow a option like applyValidOperations or something (which is by default false in a next major release)
|
@hasezoey it is a reasonable idea to throw an error if errors occurred. However, I'd like to add that in a separate PR because I would like to add that option to Probably call the option |
| } | ||
| if (ops.length === 0) { | ||
| return cb(null, getDefaultBulkwriteResult()); | ||
| } |
There was a problem hiding this comment.
This check should be moved somewhere above the if (ordered) { block. Please see #14117
Fix #13176
Summary
Make the
bulkWrite()API more consistent withinsertMany():If
ordered: false, validate all write operations, and strip out any invalid ones. Execute the valid operations.mongoose.validationErrorsto result to indicate which operations failed validation.mongoose.validationErrorsto the error to indicate which operations failed validation.I'm not thrilled with the fact that
bulkWrite()doesn't throw an error if some operations failed validation, but that is consistent with howinsertMany()works. And I'd prefer to maintain consistency, and consider changing the API for the next major release. What do you think @hasezoey ?Examples